On Sunday 11 August 2013 06:25 PM, Eddy Petrișor wrote: > You failed to reproduce the else branch in your test. The attached > test script displays the issue: > > heidi:/home/eddy/usr/src/bugs/673818# mkdir > /etc/laptop-mode/conf.d/board-specific > heidi:/home/eddy/usr/src/bugs/673818# ls > /etc/laptop-mode/conf.d/board-specific
Okay!!! Now I recollect why you are seeing this issue. This issue was fixed in 1.63, which is currently in Sid/Testing. http://ftp-master.metadata.debian.org/changelogs/main/l/laptop-mode-tools/unstable_changelog The conf.d/board-specific/ settings were added to accommodate vendors who'd like to override LMT's default values. Since 1.63, we do not ship the board-specific/ sub-folder, because that is the duty of hw vendors. With that assumption, I do not see this as a bug. Your patch is okay, but adds a subshell in it. :-( LMT already is crawling in terms of performance. Its runtime is around 7-8 secs. Now coming back to your first email: === Previously the /usr/sbin/laptop_mode script looked for files with the .conf suffix, but now every file in the /etc/laptop-mode/conf.d and /etc/laptop- mode/conf.d/board-specific directories. === Like I mentioned in one of the previous mails, I think this is fixed in commit: 6f81613ebd2ef7eba88ea2edd596f9441be2c294 I guess it is time I tag and push 1.64. -- Ritesh Raj Sarraf RESEARCHUT - http://www.researchut.com "Necessity is the mother of invention."
signature.asc
Description: OpenPGP digital signature
