Hi Joey, On Fri, Jul 19, 2013 at 11:47:43AM -0400, Joey Hess wrote: > Michael Biebl wrote: > > For upstart-only jobs, i.e. one without a corresponding SysV init script, > > dh_installinit nonetheless generates the relevant maintainer scripts > > code for the SysV init script like e.g. in udev.postinst:
> > I noticed this behaviour when looking at the udev [1] package. > AIUI this is intentional: > [ Steve Langasek ] > * dh_installinit: rework upstart handling to comply with new policy > proposal; packages will ship both an init script and an upstart job, > instead of just an upstart job and a symlink to a compat wrapper. > Closes: #577040 > However I'm not sure and perhaps dh_installinit should do something else > in this particular case. Steve will know. It's entirely possible to address this in the way that Michael describes, at the cost of added complexity in dh_installinit (more maintainer script snippet combinations, etc). Considering that there are only a handful of packages that will ever be affected by this issue (specifically, those few packages which are covered by the exception in policy to ship upstart jobs that don't have matching init scripts because they're part of the "core" of the boot system), I felt that having the complexity in the shell snippet was the right trade-off. However, if you think it's better to move the complexity to dh_installinit and have "clean" shell code, I'm happy to do this. Note that there is no buggy behavior here at package runtime, only a lintian error because lintian doesn't recognize this construction. So this could equally be considered a lintian bug instead. And there is at least one lintian bug: init.d-script-not-marked-as-conffile (warning) This lintian warning should not trigger for an init.d script that's not shipped in the package at all. So I don't think the current behavior is wrong (a handful of packages with an always-false check for /etc/init.d/foo isn't worth micro-optimizing), but will change it if you disagree. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: Digital signature
