Let's try this again. Simple, explicit test for btrfs, patch attached. On 14 July 2013 01:53, Roger Leigh <rle...@codelibre.net> wrote: > On Wed, Jul 03, 2013 at 11:27:07PM +1000, Ben Klein wrote: >> Bug still occurs with >> * btrfs-tools 0.19+20130315-2 >> * sysv-rc 2.88dsf-41 >> * sysvinit 2.88dsf-41 >> * sysvinit-utils 2.88dsf-41 >> * initscripts 2.88dsf-41 >> >> I notice this bug has been reduced in severity from "critical" to >> "important" again. Sorry, but I have to agree that it IS a critical >> bug, unless systemd has suddenly become the standard init system. > > Totally agreed; it's been set back to critical. I've been suffering > from it also. > >> Even worse, systemd is behaving incorrectly in this case, as it is >> SKIPPING fsck instead of finding the root device some other way and >> running fsck on that (though this would still trigger bug #712078). So >> ultimately, the issue is either: >> * in mountpoint's syscall for getting the device node, or >> * in checkroot.sh which needs some btrfs-specific method to find the >> correct argument to pass to btrfsck/btrfs check (taking subvolumes >> into account) >> >> I've attached an alternative patch for checkroot.sh that explicitly >> checks for btrfs and, more importantly, triggers a warning when it is >> detected. > > I didn't see an attachment. I'll be happy to look over it and apply it > --it needs to be worked around in the short term irrespective of it > being fixed down the line. Though I hope the btrfs tools are fixed > since they are currently horribly broken. > > > Thanks, > Roger > > -- > .''`. Roger Leigh > : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ > `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools > `- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
checkroot.sh-skip_btrfs.diff
Description: Binary data
