On Sun, Jun 02, 2013 at 07:02:55PM -0700, Russ Allbery wrote: > Attached is a tested patch that ports this package and the upstream > code to Apache 2.4. The patch is in a form that should be acceptable > upstream and should continue to work with Apache 2.2, although I've > not personally tested.
The patch looks good to me, for what it's worth. > I only tested with SPNEGO authentication, but I see no reason to > believe that Basic authentication wouldn't also work. > > There were two issues: first, the connection->request_ip struct member > had to be changed as mentioned in the bug report, I've been struggling with the choice between r->useragent_ip and r->connection->client_ip while porting a number of modules. I've sort of been settling down to the approach that if it's used as an element of authentication, the replacement should be client_ip (because otherwise you can forge it with a stunt proxy), and otherwise it should be useragent_ip. Does that make sense to you? If so, does that imply that client_ip should be used here instead? > I can also upload this as an NMU to help with the Apache transition if > you don't have time to look at it for a bit. I will probably do that > in the absence of a reply if we start getting towards the end of the > Apache transition to avoid having the package kicked out of testing. I've been hearing rumours that the release team would like to push through the transition this weekend and remove anything that's broken from testing then, to unblock other work. So I think it would be very helpful if you could NMU, given that there's been no (public) response. Thanks, -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
