On 2013-07-08 19:29 +0200, Colin Watson wrote:
> On Mon, Jul 08, 2013 at 06:29:42PM +0200, Sven Joachim wrote:
>> On 2013-07-06 23:23 +0200, Colin Watson wrote:
>> > I'd consider applying a patch if it were complete (i.e. handled all the
>> > packaging side of things as well). I'm unlikely to get around to this
>> > otherwise.
>>
>> Attached is a patch that adapts the Fedora unit files[2] to Debian
>> customs,
>
> Thanks, I'll look into these for my next upload.
>
>> e.g. the units test for /etc/ssh/sshd_not_to_be_run and even check
>> /dev/null (is that really necessary?).
>
> Yes. Although sshd_not_to_be_run is deprecated, bear in mind that
> people may be upgrading from old systems and expect their configuration
> still to work. I see no reason why a change of init system should
> affect that. :-)
Actually I did not mean to take out this test, but only…
> As for /dev/null, well, I never managed to track down
> what was zapping it (#369964 et al) but I would rather keep a small
> amount of cruft around to check for that than have to deal with confused
> people filing bug reports.
…the /dev/null check. While the init script can print an eligible error
message, the systemd unit files and the upstart script will fail rather
silently anyway. Actually, shouldn't the test return 1 rather than 0 in
the upstart pre-start script?
>> +ExecStartPre=/usr/bin/test -c /dev/null
>
> Does systemd really not support looking up command names on some
> reasonable $PATH?
Unfortunately, it doesn't. If no absolute path name is given, the
ExecStartPre directive is silently skipped, at least in systemd 44.
> That's a timebomb waiting to explode underneath somebody.
Yes, I'd either take the check out or run it under "/bin/sh -c" to avoid
that risk.
Cheers,
Sven
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
