Bug#714975: fdpowermon does not give warnings at low battery levels

[David Purton]

Package: fdpowermon
Version: 1.9
Severity: important
Tags: patch

Dear Maintainer,

    When trying to give a low power warning, fdpowermon fails with the
    following error message:

    ~$ fdpowermon
    *** unhandled exception in callback:
    ***   Undefined subroutine &main::warning called at /usr/bin/fdpowermon 
line 439, <$acpi> line 1.
    ***  ignoring at /usr/bin/fdpowermon line 494.


    If started when the battery level is lower than a warning point,
    fdpowermon crashes on startup:

    ~$ fdpowermon
    Undefined subroutine &main::warning called at /usr/bin/fdpowermon
    line 439, <$acpi> line 1.


    Line 439 walls the subroutine warning(), but warning() is in the
    fdpowermon::theme package. It needs to be called as
    fdpowermon::theme::warning.

    I've attached a patch to fix this.

    Thanks,

    David


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.9-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages fdpowermon depends on:
ii  acpi               1.6-1
ii  libgtk2-perl       2:1.244-1
ii  oxygen-icon-theme  4:4.8.4-1
ii  perl               5.14.2-21

Versions of packages fdpowermon recommends:
ii  libgtk2-notify-perl  0.05-3+b1

fdpowermon suggests no packages.

-- Configuration Files:
/etc/fdpowermon/theme.cfg changed [not included]

-- no debconf information

--- /usr/bin/fdpowermon	2013-07-05 10:34:32.539825561 +0930
+++ /home/dcpurton/fdpowermon	2013-07-05 10:35:33.052125626 +0930
@@ -436,7 +436,7 @@
 		next if $charging;
 		next if $wlevel >= $lastwarning;
 		if($flevel <= $wlevel) {
-			warning("battery level low (now at " . $flevel . "%)");
+                	fdpowermon::theme::warning("battery level low (now at " . $flevel . "%)");
 			$lastwarning=$flevel;
 		}
 	}