severity 330810 wishlist tags 330810 +upstream wontfix thanks On Thu, Sep 29, 2005 at 10:42:14PM +0200, Peter Paluch wrote:
> There are two problems in the present version of the sork-passwd. > First, the function name defined in /etc/sork-passwd/conf.php at the line > $conf['hooks']['default_username'] > is not used at all. Instead, the source at > /usr/share/horde2/passwd/main.php uses > '_passwd_hook_default_username' as the function name. This matches what Horde3 does; probably the sork-passwd code used this new hooks method too early in upstreams development cycle. > Second, the same main.php tries to include hooks.php which does not > exist by default. This is not really a problem but it fills up the > PHP logs. It would be probably sufficient to include an empty > /etc/horde2/hooks.php file. Another "hey, this is Horde3-style code" thing. First, I'd rather not go into another's package config directory. Second, hooks.php is included only if hooks are used. So the schema is: If you want to use hooks, define the given hook variable to true and define the function _passwd_hook_default_username in /etc/horde2/hooks.php . Else all is well. -- Lionel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
