On 19.06.2013 22:42, Dmitry Smirnov wrote: > Hi Daniel, > > Thanks for your recent corrections. Just few more left to do and I'll > upload for you.
Thanks for additional pointers and the close review - the package is going to be much better than it's Ubuntu precursor. *** control *** > * When I mentioned "unnecessary versioned dependencies" I meant that > versioning is unnecessary and safe to drop. There is no point > writing "cmake (>= 2.8.2+dfsg.1-0+squeeze1)" when just "cmake" is > enough because cmake in oldstable is above minimum requirement. > Same applies to "libqt4-dev". > > * Short package description should start with lowercase letter. Fixed. *** copyright *** 1) > * Upstream uses two emails in source files: > > Joseph Artsimovich <joseph.artsimov...@gmail.com> > Joseph Artsimovich <josep...@mail.ru> > > The latter statement appears to be older (it is often accompanied > by years 2007-2008 and one would hardly use this horrible russian > email service while having account at gmail). > > I would at least mention first statement (i.e. contact email) in > Upstream-Contact or even include both statement to copyright > paragraph as it would be speculative to decide which statement is > more important/valid. I've been in contact with Joseph over <joseph.artsimov...@gmail.com> a couple of weeks ago. I've just changed that throughout, also in the manpages. 2) > * The following copyright holders are not listed in debian/copyright: > > Vadim Kuznetsov ()DikBSD <dik...@gmail.com> > 2011 Petr Kovar <pej...@gmail.com> I've added individual paragraphs for these files. 3) > * "Based on code from the GIMP project" is not a copyright statement > so perhaps it's better to move it to Comment section. Then it would > become obvious that word "Copyright" is used twice in the > paragraph. Yes, I've moved the "based on" info of this files to Comments. 4) > * At least one file in "packaging/osx" is under BOOST license. Also > file "ScanTailor.icns" is a (sourceless?) binary file... I've added a licence paragraph for packaging/osx/user-config.jam 5) > * "License: PD" perhaps is better written as > "License: public-domain". > For files in Public-Domain copyright is not applicable so it is > better to write "Copyright: not-applicable" but mention origin of > files (i.e. Tango project and URL) in Comment field. Changed that. 6) > * One of the man pages is written by "Artem Popov <art...@gmail.com>" > but that's not how his name is written in debian/copyright. It is > always safer to use original statement as written by author without > unnecessary translation of person's name to native characters even > if it is done correctly. Yes, all right, changed that. *** misc *** 1) > * Generated man page is not removed on clean. Added debian/clean for that purpose. 2) > Probably you don't need this reminder but when convenient please > forward patch and man pages to upstream. Yes, all right, I'm going to do that. Everything has been pushed to the Git repo. Greetings, Daniel -- http://www.danielstender.com/blog/ GPG key ID: 1654BD9C -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
