Package: shadow Version: 1:4.1.5.1-1 Severity: normal User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu saucy
For some time I've noticed that, when an Ubuntu build times out (150 minutes with no output), sbuild tries to terminate it, and I see a "Session terminated, terminating shell... ...terminated." message in the log (which is from su), but the build does not actually terminate properly. Now, in both Debian and Ubuntu, sbuild invokes builds using something like this simplified command: sudo chroot $chroot su $username -s sh -c "cd $dir && exec dpkg-buildpackage" When su receives a signal, it passes it on to its child process (it has to go to unusual lengths here because it starts new sessions). However, it only kills its immediate child, not the associated process group. This means that you can do something like this: $ pgrep sleep $ su cjwatson -c 'sh -c "sleep 1h"' Password: [wait a few seconds] ^C Session terminated, terminating shell...Sessions still open, not unmounting ...killed. $ pgrep sleep 32421 This is inconvenient; in this case it means we often have to ask sysadmins to manually kill processes for us. I don't have much visibility into Debian buildds but I suspect there are similar problems there from time to time. Could su please kill the process group associated with its immediate child process instead? This should just be a matter of negating the pid passed to kill. If it did that, then I think it would do a much better job of cleaning up after itself. Thanks, -- Colin Watson [cjwat...@ubuntu.com] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
