Am 13.06.2013 20:23, schrieb Dmitrijs Ledkovs: > Package: dbus > Version: 1.6.12-1 > Severity: normal > Tags: patch > User: upst...@packages.debian.org > Usertags: upstart-job > > Dear Maintainer, > > please consider applying the following patch that adds upstart > integration for the dbus package. > > The patch below follows debian policy on alternative init systems [1] > and recommended practices in making upstart compatible init scripts > [2]. The upstart job attached will continue to honour existing > settings for additional parameters from /etc/default/dbus, just like > the current init.d script. Also conditional check whether dbus is > running under upstart is added in the dbus.postinst for the upgrade > notification. > > I have tested proposed changes on debian sid, with both sysvinit and upstart. > > [1] http://www.debian.org/doc/debian-policy/ch-opersys.html#s-alternateinit > [2] https://wiki.ubuntu.com/UpstartCompatibleInitScripts
--- dbus-1.6.12/debian/dbus.init 2013-06-12 14:41:05.000000000 +0100 +++ dbus-1.6.12/debian/dbus.init 2013-06-13 17:18:41.000000000 +0100 @@ -97,6 +97,17 @@ log_action_end_msg $? } +if init_is_upstart; then + case "$1" in + stop) + exit 0 + ;; + *) + exit 1 + ;; + esac +fi + I do not like this behaviour at all. Not only will this break 3rd party tools (monitoring, sysv editors) but I think exiting is just wrong. What the reasoning to special case stop here? I also do not particularly like that we pull in upstart specific code into the init script. It's ugly enough already as it is. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
