On Wed, Jun 12, 2013 at 08:59:28PM +0200, gregor herrmann wrote: > On Wed, 12 Jun 2013 21:49:46 +0300, Niko Tyni wrote: > > > > * Put test file jar.zip into debian/ instead of creating it with quilt. > > > Newer versions of patch don't apply git binary patches. Thanks to > > > Jakub Wilk for the bug report. (Closes: #711951)
> > FWIW, I think the only necessary fix would have been to remove the binary > > hunk from the patch file in debian/patches. It was a no-op earlier with > > the old /usr/bin/patch, and the new one is just aborting instead of > > skipping it silently. > > I suppose so but ... > > > (It doesn't hurt to shuffle jar.zip between debian/ and t/data > > but it doesn't fix anything either AFAICS.) > > ... jar.zip in the upstream t/ directory didn't look so nice. Oh, OK. (My sense of aesthetics doesn't quite agree but that's not important.) Just thought I'd clarify a bit as the changelog entry isn't quite accurate (the file wasn't created with quilt earlier, just extracted from debian.tar.gz to a different place; and older versions of patch didn't apply binary patches either but skipped them silently.) Sorry for picking nits, stopping right here :) -- Niko -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
