Control: tag -1 + patch

On Thu, 06 Jun 2013 22:36:47 +0100, Dominic Hargreaves wrote:

> Source: libeval-context-perl
> Version: 0.09.11-1
> Severity: important
> User: debian-p...@lists.debian.org
> Usertags: perl-5.18-transition
> Tags: sid jessie
> 
> This package FTBFS with perl 5.18 from experimental (in a clean sbuild
> session):
> 
> #   Failed test 'persistent variable names'
> #   at t/009_persistent_variables.t line 129.
> #     Structures begin differing at:
> #          $got->[0] = '$array'
> #     $expected->[0] = '$object'
> # 
> # |- 0 = $array  [S1]
> # |- 1 = $hash  [S2]
> # |- 2 = $object  [S3]
> # |- 3 = $variable  [S4]
> # |- 4 = @array  [S5]
> # |- 5 = $scalar  [S6]
> # `- 6 = %hash  [S7]
> # Looks like you failed 1 test of 49.
> t/009_persistent_variables.t ............ 
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/49 subtests 

Patch attached that sort the variables in the comparison.

Cheers,
gregor 

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Hildegard Knef: Tapetenwechsel
diff -Nru libeval-context-perl-0.09.11/debian/changelog libeval-context-perl-0.09.11/debian/changelog
--- libeval-context-perl-0.09.11/debian/changelog	2010-04-14 18:27:45.000000000 +0200
+++ libeval-context-perl-0.09.11/debian/changelog	2013-06-09 16:58:15.000000000 +0200
@@ -1,3 +1,12 @@
+libeval-context-perl (0.09.11-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Fix "FTBFS with perl 5.18: test failure":
+    add patch to sort variables (hash randomization)
+    (Closes: #711442)
+
+ -- gregor herrmann <gre...@debian.org>  Sun, 09 Jun 2013 16:41:17 +0200
+
 libeval-context-perl (0.09.11-1) unstable; urgency=low
 
   * Initial Release (Closes: #574615)
diff -Nru libeval-context-perl-0.09.11/debian/patches/hash-randomization.patch libeval-context-perl-0.09.11/debian/patches/hash-randomization.patch
--- libeval-context-perl-0.09.11/debian/patches/hash-randomization.patch	1970-01-01 01:00:00.000000000 +0100
+++ libeval-context-perl-0.09.11/debian/patches/hash-randomization.patch	2013-06-09 16:56:46.000000000 +0200
@@ -0,0 +1,22 @@
+Description: sort expected and retrieved variables
+ due the hash randomization in perl 5.17.* the order varies
+Origin: vendor
+Bug: https://rt.cpan.org/Dist/Display.html?Name=Eval-Context
+Forwarded: https://rt.cpan.org/Dist/Display.html?Name=Eval-Context
+Bug-Debian: http://bugs.debian.org/711442
+Author: gregor herrmann <gre...@debian.org>
+Last-Update: 2013-06-09
+
+--- a/t/009_persistent_variables.t
++++ b/t/009_persistent_variables.t
+@@ -125,8 +125,8 @@
+ 	die $@ if $@ ;
+ 	}
+ 	
+-my @persistent_variable_names = $context->GetPersistentVariableNames() ;
+-is_deeply(\@persistent_variable_names , [qw($object $array $variable %hash $hash $scalar @array)], 'persistent variable names') or diag DumpTree(\@persistent_variable_names ) ;
++my @persistent_variable_names = sort $context->GetPersistentVariableNames() ;
++is_deeply(\@persistent_variable_names , [sort qw($object $array $variable %hash $hash $scalar @array)], 'persistent variable names') or diag DumpTree(\@persistent_variable_names ) ;
+ 
+ throws_ok
+ 	{
diff -Nru libeval-context-perl-0.09.11/debian/patches/series libeval-context-perl-0.09.11/debian/patches/series
--- libeval-context-perl-0.09.11/debian/patches/series	2010-04-14 18:27:45.000000000 +0200
+++ libeval-context-perl-0.09.11/debian/patches/series	2013-06-09 16:52:30.000000000 +0200
@@ -1 +1,2 @@
 00-drop_useless_dependencies.patch
+hash-randomization.patch

Attachment: signature.asc
Description: Digital signature

Reply via email to