Package: rssh Severity: normal Tags: patch Hello,
The CFLAGS from dpkg-buildflags are missing because they are overwritten in /Makefile.am. The attached patch removes an incorrect build rule and passes the custom flags through AM_CFLAGS/AM_CPPFLAGS. All custom flags are still passed correctly. This patch should be sent to upstream if possible to fix the build system. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
Description: Respect CFLAGS from the environment. Necessary to pass (hardening) CFLAGS from dpkg-buildflags to the compiler. Author: Simon Ruderich <si...@ruderich.org> Last-Update: 2013-05-27 Index: rssh-2.3.4/Makefile.am =================================================================== --- rssh-2.3.4.orig/Makefile.am 2013-05-27 00:18:43.000000000 +0200 +++ rssh-2.3.4/Makefile.am 2013-05-27 00:20:14.139493608 +0200 @@ -1,8 +1,7 @@ ## Process this file with automake to produce Makefile.in AUTOMAKE_OPTIONS = nostdinc -ourdefs = -DPATH_RSSH_CONFIG=\"@sysconfdir@/rssh.conf\" -DPATH_CHROOT_HELPER=\"@libexecdir@/rssh_chroot_helper\" -ourflags = @defcflags@ @static@ -AM_CFLAGS = $(ourflags) +AM_CPPFLAGS = -DPATH_RSSH_CONFIG=\"@sysconfdir@/rssh.conf\" -DPATH_CHROOT_HELPER=\"@libexecdir@/rssh_chroot_helper\" +AM_CFLAGS = @defcflags@ @static@ bin_PROGRAMS = rssh libexec_PROGRAMS = rssh_chroot_helper nodist_rssh_SOURCES = main.c pathnames.h config.h @@ -15,9 +14,6 @@ EXTRA_DIST = $(man_MANS) CHROOT SECURITY LICENSE rssh.spec mkchroot.sh conf_convert.sh base=`echo @PACKAGE_STRING@|tr " " "-"` -.c.o: - $(CC) -c $(DEFS) $(ourdefs) $(AM_CFLAGS) $(CPPFLAGS) $(LDFLAGS) $< - install-exec-hook: chmod u+s $(libexecdir)/rssh_chroot_helper
signature.asc
Description: Digital signature
