Hi Sébastien, Sébastien Villemot <sebast...@debian.org> (31/01/2013): > I would like to make the attached changes to the openblas > package. The debdiff fixes several important bugs, related to > crashes or wrong results in widely used functions (dot product and > matrix-vector product). It also fixes support for 32-bit Athlon > CPUs.
for my fellow s-p-u reviewers: - bug status is good for all three bug closures in lines 1, 3, 4. - first patch looks good. - version could be 0.1.1-6+deb7u1, but I guess 0.1.1-7 would work too. Distribution needs to be changed away from UNRELEASED, too. > I consider that this patch complies with freeze policy, but since it > is not so small and is difficult to parse (x86 assembly), I prefer > to ask for pre-approval before upload. Brain hurts, yeah… For the records, that means: | $ for i in debian/patches/*; do echo $i; diffstat $i; echo; done | debian/patches/32bit_athlon.diff | setparam-ref.c | 4 ++-- | 1 file changed, 2 insertions(+), 2 deletions(-) | | debian/patches/dot_uninitialized_buffer.diff | dot_sse.S | 7 ++++--- | zdot_sse.S | 8 ++++---- | 2 files changed, 8 insertions(+), 7 deletions(-) | | debian/patches/gemv_crash_big_data.diff | x86/gemv_n_sse.S | 65 ++++++++++++++++++++++++++++++++++++------- | x86/gemv_n_sse2.S | 66 +++++++++++++++++++++++++++++++++++++------- | x86/gemv_t_sse.S | 75 +++++++++++++++++++++++++++++++++++++++++++------- | x86/gemv_t_sse2.S | 73 +++++++++++++++++++++++++++++++++++++++++-------- | x86_64/dgemv_t.S | 80 +++++++++++++++++++++++++++++++++++++++--------------- | x86_64/sgemv_t.S | 61 +++++++++++++++++++++++++++++++---------- | 6 files changed, 341 insertions(+), 79 deletions(-) | | debian/patches/sgemv_uninitialized_buffer.diff | gemv_t_sse.S | 14 ++++++++++++++ | 1 file changed, 14 insertions(+) gemv_crash_big_data.diff makes me sligtly nervous… I guess (hope) those patches were heavily tested through the later releases? Mraw, KiBi.
signature.asc
Description: Digital signature
