Niko Tyni <nt...@debian.org> writes:

> tag 708624 patch
> thanks
>
> On Fri, May 17, 2013 at 01:27:21PM +0300, Niko Tyni wrote:
>> Package: perl-tk
>> Version: 1:804.030-1
>> Severity: serious
>> Tags: sid
>>   cc -c  -I.. -I/usr/local/include  -I/usr/include/freetype2 -D_REENTRANT 
>> -D_GNU_SOURCE -DDEBIAN -fstack-protector -fno-strict-aliasing -pipe 
>> -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g   
>> -DVERSION=\"4.004\" -DXS_VERSION=\"804.03\" -fPIC 
>> "-I/usr/lib/perl/5.14/CORE"   -Wall -Wno-implicit-int -Wno-comment 
>> -Wno-unused -D__USE_FIXED_PROTOTYPES__ PNG.c
>>   make[2]: *** No rule to make target `zconf.h', needed by `imgPNG.o'.  Stop.
>
>> zlib (1:1.2.8.dfsg-1) unstable; urgency=low
>>    [...]
>>    * Install zconf.h in multiarch path (closes: #698648).
>> 
>> It looks like Tk/MakeDepend.pm needs to look in multiarch include paths
>> (/usr/include/<triplet>). Possibly the right thing to do is to parse 
>> 'cpp -v' output somewhere and feed that to Tk::MakeDepend::command_line().
>> My half hearted attempts to override INC from debian/rules weren't
>> successful.
>
> Here's a much cruder patch that makes it build for me. 
> Hope it helps a bit.

This issue was also addressed in the original perl-tk distribution. See
https://rt.cpan.org/Ticket/Display.html?id=85407 for a related bug
report. The fix is in the development release Tk-804.030_502.

> However, I note this warning in the build log:
>
>  dpkg-shlibdeps: warning: package could avoid a useless dependency if 
> debian/perl-tk/usr/lib/perl5/auto/Tk/PNG/PNG.so was not linked against 
> libz.so.1 (it uses none of the library's symbols).
>
> so presumably the whole zlib stuff is only needed for the bundled libpng
> and we shouldn't need it at all?

That's correct. 804.030_502 is now using pkg-config to check if libpng
is available, and is using this one, otherwise does a fallback to the
bundled (old!) libpng+zlib.

Regards,
    Slaven

-- 
Slaven Rezic - slaven <at> rezic <dot> de

    Berlin Perl Mongers - http://berlin.pm.org


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to