On 05/03/2013 07:05 PM, Sebastian Ramacher wrote:
Copying my message to the bug. Forgot to CC it.
----- Forwarded message from Sebastian Ramacher<sramac...@debian.org> -----
Date: Sat, 4 May 2013 01:48:31 +0200
From: Sebastian Ramacher<sramac...@debian.org>
To: Nathan Owens<ndow...@gmx.us>
Subject: Re: Bug#706688: dwb: redundant call to update-menu in maintainer
scripts
Hi Nathan,
On 2013-05-03 17:55:53, Nathan Owens wrote:
K I have rebuilt the package and uploaded to Debian Mentors
http://mentors.debian.net/debian/pool/main/d/dwb/dwb_20130424hg-2.dsc
Just gotta get it uploaded
I'd be happy to do upload it. But some of the problems mentioned in my review of
20130424hg-1 in #705698 are still not fixed. I was about to fill bugs for them
too. In particular, please fix the following points:
* Why did you add libjavascriptcoregtk-3.0-0 and libwebkitgtk-3.0-0 to dwb's
Depends? They are added to ${shlibs:Depends} by dpkg-shlibdeps anyway.
Please remove them. There is no point in having them there.
* The postinstall and postrm script do not fail on errors. Please read the
third paragraph of Policy 6.1.
Additionaly, shebangs start with #!. That's why lintian doesn't warn about the
missing set -e.
* The postrm script should be a prerm script. The shebang of both scripts can
be /bin/sh. No need for bash here.
[...]
* The copyright years in debian/copyright are not up-to-date. Please correct
them.
And now new in 20130424hg-2: is there a reson for the debhelper version bump?
compat is unchanged. debhelper also changed the versioning scheme, so that
should be a simple debhelper (>= 9) instead.
Regards
I have changed postrm to prerm because lintian gave error about the
alternative link wouldn't exist anymore and it suggested to use prerm
instead. I did that and it fixed that lintian error. There was no real
reason I changed to debhelper to 9, just like to stay current I guess. I
fixed the shebang, didn't notice the ! missing and also added set -e
right before the update-alternatives command like this: set -e
update-alternatives ...
Removed the un-needed Depends. I am currently applying the DEP-3. In the
Author field, I put the guy that wrote the changes in the git repo since
I am not the one that created the patch. That would be correct right
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
