Hi,

I agree to the opinions of Javier, Robert and - of course - Johan.

Not 24/7, changing the disks to backup on... for that, run-rsnapshot 
seems to be best. I like the good rotation from hourly to daily,
weekly and so on. Worked here well, over the last years.

Before, I started a similar try in python for doing that. That's kinda
tricky... very well done, thanks a lot!

What's missing:

sync_first 1

as 0 is dangerous... so I'd suggest the following patches (never 
before I did something in ruby, so check carefully - it seems to
work, but I am not sure):

+ add this function at the beginning:

# Find the sync_first setting from /etc/rsnapshot.conf
def sync_first
  File.new(RSNAPSHOT_CONF).each_line do |line|
    line.chomp!
    if line =~ /^sync_first\s+1$/
      return 1
    end
  end
  return 0
end

+ changed the following function
+ - asks for sync_first, than "sync" before "hourly"
+ - maybe /usr/bin/ should be added before each command
+ - ionice added

# This is the program's main piece of code
def run_rsnapshot
  # Set up the intervals

  [...]

  if update_interval
    # Launch rsnapshot with the given interval
    if update_interval.name == "hourly" and sync_first == 1
      system("nice ionice rsnapshot sync && nice ionice rsnapshot 
#{update_interval.name}")
    else
      system("nice ionice rsnapshot #{update_interval.name}")
    end
    return $?.exitstatus
  else
    return 0
  end
end


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to