Hoi, On Mon, Apr 08, 2013 at 04:57:39PM +0200, Casper Gielen wrote: > Op 06-04-13 06:35, Joost van Baal-Ilić schreef: > > Package: uruk > > Tags: patch, upstream > > > > Hoi, > > > > Thanks for your bugreport. I am submitting it to the Debian BTS, so > > it won't get lost. Please reply to <bugnr>@bugs.debian.org if you have > > any more remarks on this issue. > > > > O! On which uruk-version are you working? > > 20130226-1
That's current latest upstream, OK thanks. your patch contains: - case "$1" in - 192.168.*) echo "192.168.0.0/24" ;; - 172.16.*) echo "172.16.0.0/12" ;; - *) echo "$1" ;; - esac it misses some ranges: joostvb@janacopoulos:~/git/uruk/uruk% grep \^ip._noroute_ranges script/uruk ip4_noroute_ranges='127.0.0.1/8 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16' ip6_noroute_ranges='::1/128 ffff:0:0::/96 fc00::/7 fec0::/10 0200::/7 2001:0db8::/32' Furthermore, 172.16.0.0/12 is 172.16.0.0 - 172.31.255.255. Your code would wrongly place 172.32.0.1 in 172.16.0.0/12. Care to fix that? Hrm, there might be an easier way to work around the problem btw. We could e.g. state that autodetect-ips doesn't support that situation, and tell people to use another trick. The patch would update documentation only. I am not sure yet what's the best solution. Anyway, thanks for your work! Bye, Joost -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
