Control: severity -1 important

Dear maintainer,

I've prepared an NMU for icon (versioned as 9.4.3-4.1) and
will upload it shortly.  I've leaving this bug open because the broken
code causing these unaligned accesses is still there, and should still
be fixed.  At least one crash I saw was in the GetReal macro called from
cnv_str, fwiw.

Cheers,
Julien
diff -u icon-9.4.3/debian/changelog icon-9.4.3/debian/changelog
--- icon-9.4.3/debian/changelog
+++ icon-9.4.3/debian/changelog
@@ -1,3 +1,11 @@
+icon (9.4.3-4.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Restore -O0 on sparc and mipsel.  -O2 causes unaligned accesses, and thus
+    crashes in the test suite.
+
+ -- Julien Cristau <jcris...@debian.org>  Fri, 22 Mar 2013 15:22:08 +0000
+
 icon (9.4.3-4) unstable; urgency=medium
 
   * Apply patch from Aurelien Jarno: instead of disabling all optimizations
diff -u icon-9.4.3/debian/rules icon-9.4.3/debian/rules
--- icon-9.4.3/debian/rules
+++ icon-9.4.3/debian/rules
@@ -5,6 +5,7 @@
 
 DEB_HOST_ARCH_OS := $(shell dpkg-architecture -qDEB_HOST_ARCH_OS 2>/dev/null)
 DEB_HOST_ARCH_CPU := $(shell dpkg-architecture -qDEB_HOST_ARCH_CPU 2>/dev/null)
+DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH 2>/dev/null)
 
 # Take account of old dpkg-architecture output.
 
@@ -22,7 +23,11 @@
 endif
 
 # The current code use type-punning and signed overflow
+ifneq (,$(filter $(DEB_HOST_ARCH), sparc mipsel))
+CFLAGS_OPT = -O0
+else
 CFLAGS_OPT = -O2 -fno-strict-aliasing -fno-strict-overflow
+endif
 
 ifneq (, $(filter $(DEB_HOST_ARCH_OS), linux kfreebsd knetbsd))
     system = linux

Attachment: signature.asc
Description: Digital signature

Reply via email to