On Fri, 2013-03-15 at 03:33 +0000, Clint Adams wrote: > > On newer vserver patches a better check is to look for a VxID line in > > /proc/self/status. If the line is present you're running a vserver > > kernel. If the value is 0, then you're on the physical host, anything > > else means you're in a vserver. > > I wonder if it's better to have the initscripts postinst do the grep > than to parse /proc/self/status in ischroot.
The big downside to that approach that I can see is that according to
the changelog ischroot was implemented to *stop* people having checks
spread all over the place. And as we've just discovered those checks
break over time as things progress. Better to have them in one place,
than spread around.
I guess that question comes down to, is the mount that initscripts
postinst doing appropriate in chroots in general? At a guess no,
otherwise it wouldn't use ischroot.
I have proposed patch for ischroot that is attached to bug #703012
(curse the BTS for not creating my bug reports in a timely manner).
Cheers!
--
Andrew Ruthven
Wellington, New Zealand
At home: and...@etc.gen.nz | linux.conf.au 2013
| Come join the party...
| http://linux.conf.au
signature.asc
Description: This is a digitally signed message part
