On 13.03.2013 08:55, Michael Biebl wrote: > On 12.03.2013 21:45, Mathieu Trudel-Lapierre wrote: >> Fair enough. I started, or more precisely cleaned up what I had a bit and >> rebased on 0.7.990; it builds here on Ubuntu and I shipped it to a PPA to >> build "cleanly": > > Thanks for that! > >> https://launchpad.net/~network-manager/+archive/modemmanager-next/+sourcepub/3023373/+listing-archive-extra >> >> It builds fine in sbuild here with libqmi 1.0-1. I'll track it later to see >> whether it completes this build. Then there is some work done by Marius >> Kotsbak I'll merge, and I'll be ready for constructive criticism (ie. >> sponsoring). > > I've had a quick look at it, a couple of comments:
One more: 1/ Do you really want to make libmm-glib0 depend on modemmanager? Why is that needed? This creates a nasty dependency loop. Is this for the plugins? Having them in modemmanager also results in E: modemmanager: pkg-has-shlibs-control-file-but-no-actual-shared-libs W: modemmanager: postinst-has-useless-call-to-ldconfig W: modemmanager: postrm-has-useless-call-to-ldconfig If libmm-glib0 is supposed to be a standalone library and needs those plugins, then they should be moved into libmm-glib0 (assuming upstream bumps the Version in the directory path) or have them in a libmm-glib-runtime package with libnm-glib0 depending on that. If those modules are used by ModemManager and *not* by libmm-glib0, keep them in the modemmanager package but exclude them from dh_makeshlibs. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
