Package: clive
Version: 2.2.13-5+squeeze5
Severity: normal

App.pm checks URL for string 'http://' and prepends it if it is not found:

sub _parseLine {
    my ( $self, $ln ) = @_;

    return if $ln =~ /^$/;
    return if $ln =~ /^#/;

    chomp $ln;

    $ln = "http://$ln";
        if $ln !~ m{^http://}i;
[...]

However this breaks HTTPS:

$ clive --no-proxy 'https://www.youtube.com/watch?v=ZTTzcXSLjhI'
fetch http://https://www.youtube.com/watch?v=ZTTzcXSLjhI ...
error: Couldn't resolve host name (http/6)
$ 

This would be better parser code:

    $ln = "http://$ln";
        if $ln !~ m{^https?://}i;

Gabor

-- System Information:
Debian Release: 6.0.7
  APT prefers proposed-updates
  APT policy: (500, 'proposed-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages clive depends on:
ii  libclass-singleton-per 1.4-1             implementation of a "Singleton" cl
ii  libconfig-tiny-perl    2.12-1            Read/Write .ini style files with a
ii  libexpect-perl         1.20-2            Expect.pm - Perl Expect interface
ii  libgetopt-argvfile-per 1.11-1            Perl module for reading script opt
ii  libhtml-parser-perl    3.66-1            collection of modules that parse H
ii  liburi-perl            1.54-2            module to manipulate and access UR
ii  libwww-curl-perl       4.12-1            Perl bindings to libcurl
ii  perl                   5.10.1-17squeeze6 Larry Wall's Practical Extraction 

Versions of packages clive recommends:
ii  clive-utils              2.1.6-1         additional utilities for clive
ii  libberkeleydb-perl       0.42-1~squeeze1 use Berkeley DB 4 databases from P
ii  libterm-readkey-perl     2.30-4          A perl module for simple terminal 

Versions of packages clive suggests:
ii  ffmpeg                     5:0.7.15-dmo1 audio/video encoder, streaming ser

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to