On Wed, 6 Mar 2013, Mikołaj Izdebski wrote:
lbzip2 development (git master)
-z -zc -zf -zcf -d -dc -df -dcf -t -tf
regular file 1 1 1 1 1 1 1 1 1 1
symlink to regular file M 1 1 M 1 1 M 1
device M 1 1 M 1 1 M 1
symlink to device M 1 1 M 1 1 M 1
Gentoo lbzip2
-z -zc -zf -zcf -d -dc -df -dcf -t -tf
regular file 1 1 1 1 1 1 1 1 1 1
symlink to regular file 1 1 G G 1 1 G 1
device 1 1 G G 1 1 G 1
symlink to device 1 1 G G 1 1 G 1
These help the discussion greatly, thanks!
On the surface, neither "relaxation patch" seems to be a subset of the
other. However, what Gentoo actually cares about is -dc (IIRC); they need
it for some kind of automated installation procedure (part of emerge or
some such). So, Gentoo's relaxation of the plain -d case is actually wrong
(I recall noticing that when I had seen their patch for the first time),
but in practice they don't invoke plain -d on non-regular files, so it
doesn't bother them probably.
Hence my observation: you shouldn't need to adopt anything from the Gentoo
patch (your patch is correct & complete), but your commit actually covers
the one case Gentoo cares about, so they could drop their out-of-tree
patch when upgrading their package next time.
(Ugh, apologies, Debian, we should really be discussing this in the Gentoo
bugzilla.)
Laszlo
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
