Source: gnotime
Version: 2.3.1~snapshot20091119-5
Severity: important
User: pkg-gnome-maintain...@lists.alioth.debian.org
Usertags: oldlibs pangox
Hi,
gnotime checks for pangox but doesn't actually need it (there are no pango_x_
function calls or pangox.h includes).
pangox has been deprecated upstream for many years and has already been removed
from pango.
Please consider applying (after the freeze) the attached patch to stop checking
for pangox and so avoid problems with the new pango1.0 sources.
Note that the X11 check is kept as gnotime uses X11. However X_LIBS is not used
in any Makefile. Ideally, $(X_LIBS) would be used in place of -lX11 in
01_fix_ftbfs_binutils-gold.diff
Thanks,
Emilio
Description: Don't check for pangox, it's not needed.
Bug-Debian:
Author: Emilio Pozuelo Monfort <po...@debian.org>
--- a/configure.in
+++ b/configure.in
@@ -238,26 +238,12 @@
dnl X development libraries check
dnl ************************************************
-if $PKG_CONFIG --exists pangoxft ; then
- PANGO_PACKAGES="pangox pangoxft"
-else
- PANGO_PACKAGES="pangox"
-fi
-
-x_libs="`$PKG_CONFIG --libs $PANGO_PACKAGES`"
-case x_libs in
- *-lX11*) pango_omitted_x_deps=no ;;
- *) pango_omitted_x_deps=yes ;;
-esac
+AC_PATH_XTRA
-if test $pango_omitted_x_deps = yes ; then
- AC_PATH_XTRA
-
- if test x$no_x = xyes ; then
- AC_MSG_ERROR([X development libraries not found])
- else
- X_LIBS="$X_PRE_LIBS $X_LIBS -lX11 $X_EXTRA_LIBS"
- fi
+if test x$no_x = xyes ; then
+ AC_MSG_ERROR([X development libraries not found])
+else
+ X_LIBS="$X_PRE_LIBS $X_LIBS -lX11 $X_EXTRA_LIBS"
fi
AC_SUBST(X_LIBS)
--- a/configure
+++ b/configure
@@ -8866,20 +8866,7 @@
-if $PKG_CONFIG --exists pangoxft ; then
- PANGO_PACKAGES="pangox pangoxft"
-else
- PANGO_PACKAGES="pangox"
-fi
-
-x_libs="`$PKG_CONFIG --libs $PANGO_PACKAGES`"
-case x_libs in
- *-lX11*) pango_omitted_x_deps=no ;;
- *) pango_omitted_x_deps=yes ;;
-esac
-
-if test $pango_omitted_x_deps = yes ; then
- if test "$no_x" = yes; then
+if test "$no_x" = yes; then
# Not all programs may use this symbol, but it does not hurt to define it.
$as_echo "#define X_DISPLAY_MISSING 1" >>confdefs.h
@@ -9370,11 +9357,10 @@ fi
fi
- if test x$no_x = xyes ; then
- as_fn_error "X development libraries not found" "$LINENO" 5
- else
- X_LIBS="$X_PRE_LIBS $X_LIBS -lX11 $X_EXTRA_LIBS"
- fi
+if test x$no_x = xyes ; then
+ as_fn_error "X development libraries not found" "$LINENO" 5
+else
+ X_LIBS="$X_PRE_LIBS $X_LIBS -lX11 $X_EXTRA_LIBS"
fi
