Package: git-stuff
Version: 15-1
Severity: normal
Tags: patch
I tried to set hooks.envelopsender as documented in the script
git-hook-notification-email, but it fails like this:
$ cd /var/cache/git/my-project.git
$ git config --get hooks.envelopesender
raf...@laboissiere.net
$ echo ff00d7e d484d6b refs/heads/master |
/usr/bin/git-hook-notification-email
exim: bad -f address "'raf...@laboissiere.net'": malformed address: ' may
not follow 'raf...@laboissiere.net
I am using package exim4 version 4.80-7.
There is something wrong with the quotes at line 673 of the script
git-hook-notification-email. The patch attached below fixes the problem
for me. this fix only works when there are no spaces in
hooks.envelopsender and I think that the quotes were originally meant for
that case, so a more general solution should be sought.
Rafael
-- System Information:
Debian Release: 7.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages git-stuff depends on:
ii debconf [debconf-2.0] 1.5.49
ii git 1:1.7.10.4-1+wheezy1
Versions of packages git-stuff recommends:
ii cron 3.0pl1-124
ii git-buildpackage 0.6.0~git20120601
ii mr 1.12
ii pristine-tar 1.25
Versions of packages git-stuff suggests:
pn gitstats <none>
pn irker <none>
-- debconf information:
git-stuff/bash-profile: false
git-repack-repositories/cron: @monthly
git-repack-repositories/enable: false
git-stuff/title:
git-repack-repositories/directories: /srv/git
git-repack-repositories/title:
diff -Naur a/git-hook-notification-email b/git-hook-notification-email
--- a/git-hook-notification-email 2013-02-25 14:45:19.000000000 +0100
+++ b/git-hook-notification-email 2013-02-25 14:47:32.000000000 +0100
@@ -670,7 +670,7 @@
PAGER= generate_email $2 $3 $1
else
if [ -n "$envelopesender" ]; then
- sendmail="$sendmail -f '$envelopesender'"
+ sendmail="$sendmail -f $envelopesender"
fi
while read oldrev newrev refname
