On Sun, Feb 17, 2013 at 10:59:03PM -0800, Vincent Cheng wrote: > A pedantic note: You may (or may not) want to be more verbose in > debian/changelog. Generally, when doing a NMU upload it's safer to be > on the more verbose side; you should at least be as verbose as the > maintainer was in previous changelog entries. e.g. adding a new > binary package is IMHO significant enough to warrant its own changelog > entry, and including a brief justification makes the ftpmasters' lives > easier (source packages uploaded that also add new binary packages > will end up taking a trip through the NEW queue). Also, modifying > build-depends, package relationships in debian/control should be > mentionned in the changelog. Anyways, this is more of a judgment call, > but being more verbose in your changelog will make it easier for > others to review your package. I have updated the changelog to be more verbose. Is there anything else I should mention in it?
> A not-so-pedantic note: debian/copyright is still incomplete. e.g.: > - src/shader.cpp: Copyright (C) 2012 Kahrl <ka...@gmx.net> > - src/guiPasswordChange.cpp: Copyright (C) 2011 Ciaran Gultnieks > <cia...@ciarang.com> > - src/filecache.cpp: Copyright (C) 2012 Jonathan Neuschäfer > <j.neuschae...@gmx.net> > > "licensecheck --copyright -r . | /usr/lib/cdbs/licensecheck2dep5 > > debian/copyright_new" should list the above, and a few more missing > copyright holders (compare with your current debian/copyright file). > It's less hassle for everyone involved if you get it right on the > first try, instead of ftpmasters rejecting your package due to an > incomplete debian/copyright (I speak from experience). Thanks for pointing that out. I noticed that upstream changed license to LGPL-2 in commit 037b259. Anyway, I have updated the debian/copyright file to reflect this change and to include the missing copyright holders. Also, I have updated debian/watch and get-orig-source in debian/rules to point to github.com/minetest/minetest because upstream moved there. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
