Package: pristine-tar Version: 1.26 Severity: normal Tags: patch Dear Maintainer,
I have some automated processes using pristine-tar in a number of different situations. I noticed that some tests were failing with an odd error from pristine-tar in certain cases: "unsupported vcs git at /usr/bin/pristine-tar line 812." But I was somewhat sure that pristine-tar does, in fact, support git. Turns out this happens when using "pristine-tar list" in a repo that doesn't have any pristine-tar branch. There's a misplaced right curly-brace that causes the "unsupported vcs" message (and a nonzero exit code) instead of an empty list, and in the case that "pristine-tar list" really is run under an unsupported vcs, no error would be printed (although that's moot for now, because vcstype() doesn't ever return anything besides "git" yet). Running "pristine-tar list" when there /is/ a pristine-tar branch works fine. I would expect, when there is no pristine-tar branch, for "pristine-tar list" to output nothing to stdout or stderr and exit with 0. Inlined patch here makes fixy: --- /usr/bin/pristine-tar 2012-08-25 10:09:24.000000000 -0600 +++ pristine-tar 2013-02-12 11:01:24.707999463 -0700 @@ -808,9 +808,8 @@ print $_."\n"; } } + } else { die "unsupported vcs $vcs"; } } - -} -- System Information: Debian Release: 7.0 APT prefers testing APT policy: (900, 'testing'), (500, 'stable'), (50, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages pristine-tar depends on: ii libbz2-1.0 1.0.6-4 ii libc6 2.13-37 ii perl-modules 5.14.2-17 ii xdelta 1.1.3-9 ii zlib1g 1:1.2.7.dfsg-13 Versions of packages pristine-tar recommends: ii bzip2 1.0.6-4 pn pbzip2 <none> ii xz-utils 5.1.1alpha+20120614-2 pristine-tar suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org