Package: xournal Version: 4.7-1 Severity: wishlist I was told to have a look at xournal and I have to say that this is a remarkably useful tool. One use case I like in particular is annotating existing pdf files. Then I need to synchronize those annotations somehow. For some people "git" is the obvious answer here. So I had a look at what those .xoj files actually are. They are gzip compressed xml files in a format that is suitable for line-diffing (after decompression). Unfortunately the compression breaks efficient storage of .xoj files in git (since its deltas would apply to the already compressed objects) and nice diffing. This can be worked around in git by providing so called smudge and clean filters.
So for some reason xournal appears to be happy to read uncompressed .xoj files. Maybe gzopen just reads the uncompressed data if there is no gzip marker. It would be nice to set some .xournal/config setting to also save uncompressed. Would that be possible? Feel free to tag this bug as wontfix. On a related note in save_journal() there is this snippet: > tmpf = fopen(tmpfn, "wb"); > if (tmpf != NULL && fwrite(bgpdf.file_contents, 1, bgpdf.file_length, tmpf) > == bgpdf.file_length) > success = TRUE; > fclose(tmpf); Please avoid the NULL pointer dereference that occurs in fclose if fopen fails. That would be one segfault less. ;-) Helmut -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
