Jonathan Wiltshire <j...@debian.org> wrote:
>On Tue, Jan 22, 2013 at 04:23:43PM +0000, Jonathan Wiltshire wrote:
>> On 2013-01-22 13:15, Thomas Preud'homme wrote:
>> >Sorry to come again with an issue on dspam again. This time it's
>> >about
>> >bug #698580 - useless prompting at upgrade when no configuration
>file
>> >have been modified. A mistake was made which made
>> >/etc/dspam/dspam.d/{pgsql,mysql}.conf be conffiles and yet managed
>by
>> >ucf. This patch move ucf template from /etc to /usr/share
>> >subdirectories
>> >to avoid them being conffiles. See attached debdiff for the details
>> >(avoid_useless_prompt.debdiff).
>> >
>> >As before, the package being different in testing and sid, the fix
>> >would
>> >have to go through tpu. The fix has just been uploaded to sid for
>> >more
>> >testing.
>> >
>> >I would also like to include the fix for #698136. I know it's only
>of
>> >severity important but it's a simple oneliner fix so maybe you'll
>> >agree
>> >for it anyway. See [1] for the patch.
>> >
>> >[1]
>> >
>>
>>http://patch-tracker.debian.org/patch/series/view/dspam/3.10.2+dfsg-4/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
>>
>> I'm happy with both these changes provided they have had sufficient
>> testing in unstable first. (I presume the destination in the
>> strcpy() call is large enough not to overflow?)
>
>Ping?
Sorry, I've been busy recently. The overflow is a very good remark which I
should have wondered myself. I didn't because I took the patch upstream and it
was reviewed by the main upstream author. Also I was probably absent minded.
Anyway, I tried to get certainty by reading the code to see any assumption the
code is using but I couldn't understand enough of the code. So I reached
upstream and he shall give me an explanation about wether it's safe or not and
why in the next days.
I'll get back to you asap.
Best regards.
Thomas
By the way, my condolence for entering the RT ;-)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
