tags 673038 - patch thanks
2013/1/27 Ben Hutchings <b...@decadent.org.uk>: > On Sat, 2013-01-26 at 23:45 +0100, Bálint Réczey wrote: >> Hi Ben, >> >> 2013/1/26 Ben Hutchings <b...@decadent.org.uk>: >> > On Sat, 2013-01-26 at 00:08 +0100, Bálint Réczey wrote: >> >> tags 673038 patch upstream - moreinfo >> >> thanks >> >> >> >> Hi, >> >> >> >> Upstream seems to know about the problem and I provided a fix for them >> >> with a documentation update. >> >> Slapcat's exit code is 1 in case of missing entries thus an >> >> unsuccessful backup attempt can be detected. >> > [...] >> > >> > Really, that's not what it says here: >> > https://github.com/elmar/ldap-git-backup/blob/master/README.mdown#safe-ldif >> > >> > Is there an upstream bug fix that makes the exit code non-zero? >> Looking at slapcat.c the intention is returning 1 on errors while not >> all error cases seem to be covered: >> http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=blob;f=servers/slapd/slapcat.c;h=6bd9293fe4e980dcd1d7d4a1ccd1a644062fb346;hb=HEAD >> >> IMO the documentation should reflect the intention and the code should >> be fixed if it does not do what the documentation says. > > I think we're all in agreement that the code should be fixed. Please > help to do that, if you can. Upstream has rejected the proposed fix. Since it seems I'm not familiar enough with upstream's plans and coding practices I'm not the best person to provide a fix. Upstream BTW don't see this issue as an important one and recommends using the mdb back-end which is expected to be much faster in most cases and also does not exhibit this problem. Regarding the Debian Project IMO the best option would be living with the bug, relying on the workaround for backups and releasing Wheezy with this bug present. Cheers, Balint -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
