Bug#696435: [PATCH] connect to local host if transport is "ssh" and no listen tag is set in the domain

[Attila Kinali]

Hi,

I think this bug is described in [1] and has been patched in upstream
using [2]. I modified the patch slightly to apply to 0.5.3, but it's rather
a quick hack and proof that it works rather than a proper fix.

I also guess that this bug is a dublicate of #684725, but that the actual
behaviour only slightly differs (i've seen totally different error message
on ubuntu with the same package, which is also fixed by this patch)


                        Attila Kinali




[1] https://www.redhat.com/archives/virt-tools-list/2012-November/msg00006.html
[2] https://www.redhat.com/archives/virt-tools-list/2012-November/msg00018.html

-- 
There is no secret ingredient
         -- Po, Kung Fu Panda

--- virt-viewer-0.5.3.orig/src/virt-viewer.c
+++ virt-viewer-0.5.3/src/virt-viewer.c
@@ -354,10 +354,17 @@ virt_viewer_extract_connect_info(VirtVie
     if (!ghost ||
         (strcmp(ghost, "0.0.0.0") == 0 ||
          strcmp(ghost, "::") == 0)) {
+	 char *replace = NULL;
+	if(strcmp(transport, "ssh") == 0)
+	{
+		replace = "localhost";
+	} else {
+		replace = host;
+	}
         DEBUG_LOG("Guest graphics listen '%s' is NULL or a wildcard, replacing with '%s'",
-                  ghost ? ghost : "", host);
+                  ghost ? ghost : "", replace);
         g_free(ghost);
-        ghost = g_strdup(host);
+        ghost = g_strdup(replace);
     }
 
     virt_viewer_app_set_connect_info(app, host, ghost, gport, gtlsport,transport, unixsock, user, port, NULL);