The bug is introduced in line 104 of patch: 0007-add-lightdm-support.patch

102+        GError *local_error = NULL;
103+
104+        if (!g_file_test ("/etc/gdm", G_FILE_TEST_EXISTS))
105+                return TRUE; /* not an error, just not installed */

It is checked for existence of directory /etc/gdm which does not exist in
Wheezy. Rather, GDM configuration is stored in /etc/gdm3/daemon.conf (as
correctly defined in source: #define PATH_GDM_CUSTOM "/etc/gdm3/daemon.conf").

As a result, g_file_test ("/etc/gdm", G_FILE_TEST_EXISTS) fails in any case
and GDM settings are never being stored.

Therefore, the test for "installed" gdm must read:

-        if (!g_file_test ("/etc/gdm", G_FILE_TEST_EXISTS))
+        if (!g_file_test ("/etc/gdm3", G_FILE_TEST_EXISTS))


Here is a debdiff which fixes the issue, please assist how to proceed best:

diff -Nru accountsservice-0.6.21/debian/changelog 
accountsservice-0.6.21/debian/changelog
--- accountsservice-0.6.21/debian/changelog     2012-11-03 12:16:42.000000000 
+0100
+++ accountsservice-0.6.21/debian/changelog     2012-12-18 23:00:00.000000000 
+0100
@@ -1,3 +1,11 @@
+accountsservice (0.6.21-7.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Fix mistake in 0007-add-lightdm-support.patch which prevents
+    saving of autologin settings for gdm3 (Closes:  #680786)
+
+ -- Jean-Peer Lorenz <peer....@gmx.net>  Tue, 18 Dec 2012 22:21:47 +0100
+
 accountsservice (0.6.21-7) unstable; urgency=low
 
   [ Simon McVittie ]
diff -Nru 
accountsservice-0.6.21/debian/patches/fix-add-lightdm-support-for-gdm.patch 
accountsservice-0.6.21/debian/patches/fix-add-lightdm-support-for-gdm.patch
--- accountsservice-0.6.21/debian/patches/fix-add-lightdm-support-for-gdm.patch 
1970-01-01 01:00:00.000000000 +0100
+++ accountsservice-0.6.21/debian/patches/fix-add-lightdm-support-for-gdm.patch 
2012-12-18 22:31:18.000000000 +0100
@@ -0,0 +1,13 @@
+Index: accountsservice-0.6.21/src/daemon.c
+===================================================================
+--- accountsservice-0.6.21.orig/src/daemon.c   2012-12-18 22:21:40.000000000 
+0100
++++ accountsservice-0.6.21/src/daemon.c        2012-12-18 22:30:50.387017183 
+0100
+@@ -1316,7 +1316,7 @@
+         gboolean result;
+         GError *local_error = NULL;
+ 
+-        if (!g_file_test ("/etc/gdm", G_FILE_TEST_EXISTS))
++        if (!g_file_test ("/etc/gdm3", G_FILE_TEST_EXISTS))
+                 return TRUE; /* not an error, just not installed */
+ 
+         keyfile = g_key_file_new ();
diff -Nru accountsservice-0.6.21/debian/patches/series 
accountsservice-0.6.21/debian/patches/series
--- accountsservice-0.6.21/debian/patches/series        2012-11-03 
12:15:25.000000000 +0100
+++ accountsservice-0.6.21/debian/patches/series        2012-12-18 
22:32:19.000000000 +0100
@@ -9,3 +9,4 @@
 9002-memory_leak_actuser.c
 9003-CVE-2012-2737.patch
 9004-ActUserManagerNewSession-do-not-free-if-there-are-pe.patch
+fix-add-lightdm-support-for-gdm.patch


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to