Hi!

On Sun, 2012-12-02 at 22:40:04 +0100, Salvo Tomaselli wrote:
> Package: dpkg
> Version: 1.16.9
> Severity: normal

> after inspecting start-stop-daemon's source, i couldn't find any wait/waitpid
> calls, and they should exist.

That's because those calls only apply to child processes which is not
the case with s-s-d --stop.

> Stopping a daemon usually consists in sending a message to the right pid, but
> after that it would be better to do a waitpid so that the command terminates
> when the daemon has really stopped, not just when the signal has been sent.

That behaviour is already supported with the --retry option. But this
might not cover the case that a parent process in the daemon has
terminated but not some of its worker childs for example, and that's
a daemon's issue.

> This would allow scripts to be simpler because they would know that after a
> "start-stop-daemon --stop", the daemon has in fact stopped; and it's not the
> case right now.

Then those init scripts are buggy, and should be fixed.

> This leads maintainers to insert sleeps in the scripts to hope that in the
> meanwhile the daemon will terminate (the correct approach would be to insert
> wait on the pid); but the even more correct approach would be to fix
> start-stop-daemon so that when it exits the daemon has stopped.

This is either a problem in the daemon, or in the init script, I don't
really see any issue here with s-s-d. If no further information to the
contrary is provided I'll be closing this report.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to