Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Requesting an unblock of playmidi. Changes are fairly minimal: * change of maintainer email address * use of standard build flags (via dpkg-buildflags) * debhelper compat bump, 4 → 5 * standards version bump * fixing of some lintian warnings (dep on dpkg-dev, copyright file fixes) Also, NMUs are acknowledged. Diff is attached. [Testing the water with this one – I have three other packages with very similar changes. However, even if not unblocked, one objective should be achieved – that of updating my email address with regard to these packages. I do see a few missed bug reports as a result of not having got these uploaded sooner.] -- | _ | Darren Salt, using Debian GNU/Linux (and Android) | ( ) | | X | ASCII Ribbon campaign against HTML e-mail | / \ | http://www.asciiribbon.org/ To err is human; to forgive is out of the question.
diff -u playmidi-2.4debian/Makefile playmidi-2.4debian/Makefile --- playmidi-2.4debian/Makefile +++ playmidi-2.4debian/Makefile @@ -47,8 +47,10 @@ INSTALL = install -s # if you are using the GUS Ultra driver module, add -DULTRA_DRIVER -CFLAGS = -Wall -pipe -fomit-frame-pointer -O2 $(INCAWE) -LDFLAGS = +#CFLAGS = -Wall -pipe -fomit-frame-pointer -O2 $(INCAWE) +CFLAGS ?= -Wall -pipe -fomit-frame-pointer -O2 +CFLAGS += $(INCAWE) +#LDFLAGS = OBJECTS = playmidi.o readmidi.o playevents.o \ patchload.o emumidi.o io_ncurses.o diff -u playmidi-2.4debian/debian/compat playmidi-2.4debian/debian/compat --- playmidi-2.4debian/debian/compat +++ playmidi-2.4debian/debian/compat @@ -1 +1 @@ -4 +5 diff -u playmidi-2.4debian/debian/changelog playmidi-2.4debian/debian/changelog --- playmidi-2.4debian/debian/changelog +++ playmidi-2.4debian/debian/changelog @@ -1,3 +1,14 @@ +playmidi (2.4debian-10) unstable; urgency=low + + * Change of maintainer address. + * Bump standards version to 3.9.3; bump debhelper compat to 5 (minimal). + * Copyright file fixups (lintian warning). + * Use dpkg-buildflags for hardening. + * Add a versioned build-dep on dpkg-dev. + * Ack NMUs. (Closes: #463252, #488708, #489161, #654813, #665305) + + -- Darren Salt <devs...@moreofthesa.me.uk> Tue, 20 Nov 2012 18:05:29 +0000 + playmidi (2.4debian-9.2) unstable; urgency=low * Non-maintainer upload. diff -u playmidi-2.4debian/debian/control playmidi-2.4debian/debian/control --- playmidi-2.4debian/debian/control +++ playmidi-2.4debian/debian/control @@ -1,9 +1,9 @@ Source: playmidi Section: sound Priority: optional -Maintainer: Darren Salt <li...@youmustbejoking.demon.co.uk> -Standards-Version: 3.7.3 -Build-Depends: debhelper (>= 4.1.16), libncurses5-dev | libncurses-dev, libxaw7-dev, libxt-dev +Maintainer: Darren Salt <devs...@moreofthesa.me.uk> +Standards-Version: 3.9.3 +Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 4.1.16), libncurses5-dev | libncurses-dev, libxaw7-dev, libxt-dev Package: playmidi Architecture: any diff -u playmidi-2.4debian/debian/copyright playmidi-2.4debian/debian/copyright --- playmidi-2.4debian/debian/copyright +++ playmidi-2.4debian/debian/copyright @@ -7,9 +7,8 @@ Upstream Author: Copyright: - -(c) Nathan I Laredo <lar...@gnu.org> -GTK interface (c) Nathan Laredo, Elliot Lee <no address present> + © 1994-2009 Nathan I Laredo <lar...@gnu.org> + GTK interface (c) Nathan Laredo, Elliot Lee <no address present> Licence: diff -u playmidi-2.4debian/debian/rules playmidi-2.4debian/debian/rules --- playmidi-2.4debian/debian/rules +++ playmidi-2.4debian/debian/rules @@ -5,13 +5,8 @@ # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 -CFLAGS = -Wall -g - -ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) - CFLAGS += -O0 -else - CFLAGS += -O2 -endif +DPKG_EXPORT_BUILDFLAGS = 1 +include /usr/share/dpkg/buildflags.mk #DEB_HOST_ARCH := $(shell dpkg-architecture -qDEB_HOST_ARCH) #ifeq ($(DEB_HOST_ARCH),i386) @@ -24,8 +19,7 @@ build: build-stamp build-stamp: debian/po/templates.pot dh_testdir - echo 2 | $(MAKE) INCNC= INCAWE= CFLAGS="$(CFLAGS)" \ - playmidi xplaymidi $(splaymidi) + echo 2 | $(MAKE) INCNC= INCAWE= playmidi xplaymidi $(splaymidi) touch build-stamp clean:
