On Sun, Nov 18, 2012 at 02:02:22PM -0500, Neil Roeth wrote:
> Thanks for the report. I will take a look and fix in the next version.
>
> On 11/16/2012 08:02 AM, Roland Mas wrote:
> >Package: psgml
> >Version: 1.3.2-14
> >Severity: normal
> >
> >The current psgml doesn't seem to work with Emacs 24 as shipped in
> >Debian. I first thought it was due to a lack of emacsen-install, but
> >even if I byte-compile it by hand I get the following error on opening
> >an XML file with psgml loaded (from the *Messages* buffer):
This is indeed what also happens with emacs-snapshot. psgml
byte-compilation seems deliberately disabled for emacs24, probably
because of this.
> >
> >,----
> >| Loading psgml...done
> >| File mode specification error: (void-function make-local-hook)
> >`----
Note that this is probably the same as
#669280
psgml: 'local automatically makes hook buffer-local in Emacs,
make-local-hook is only for XEmacs
where I suggested a patch for this, but seems not the real error, just a
warning.
> >
> > Then my buffer has no font-lock and the psgml functions (and keyboard
> >bindings) lead to errors such as:
> >
> >,----
> >| cons: Invalid function: (\` (defmacro ((\, (intern (format
> >"sgml-eltype-%s" n)))) (et) (list (quote get) et (quote (quote ((\, n)))))))
> >`----
I recently filed a bug report about old-style backquotes in psgml.el
[#669282 psgml: Still using old style backquotes], but it covered only the
`( ... ) case in psgml.el. Seems that there are a lot of other obsolete
backquotes, in particular in sgml-parse.el. For most cases this should only
cause a harmless warning, but seems that in the case of `sgml-prop-fields'
macro definition this is causing more harm. I changed the backquotes use in
that definition and error seems to go, see attached patch.
There are probably other issues, e.g., seems I lose font-lock for
psgml+emacs-snapshot, but while this seems not related to this change,
cannot make sure.
Regards,
--
Agustin
>From 45f08726e68b530e49db8ed07c11864360c70963 Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo <agmar...@debian.org>
Date: Mon, 19 Nov 2012 13:06:15 +0100
Subject: [PATCH 3/3] psgml-parse.el: Do not use old-style backquotes in
`sgml-prop-fields'
---
psgml-parse.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/psgml-parse.el b/psgml-parse.el
index 8565558..f830869 100644
--- a/psgml-parse.el
+++ b/psgml-parse.el
@@ -908,8 +908,8 @@ If ATTSPEC is nil, nil is returned."
(cons
'progn
(loop for n in names collect
- (`(defmacro (, (intern (format "sgml-eltype-%s" n))) (et)
- (list 'get et ''(, n)))))))
+ `(defmacro (, (intern (format "sgml-eltype-%s" n))) (et)
+ (list 'get et ''(, n))))))
(sgml-prop-fields
;;flags ; optional tags and mixed
--
1.7.10.4
