On Mon, 2012-11-12 at 00:39 -0800, Jonathan Nieder wrote: [...] > While the patches are both useful for insight, the userspace patch, if > widely deployed, would make the kernel interface impossible to fix. > Please make sure anyone applying it knows what they are doing. The > test it uses for the broken ABI is > > if(strcmp(uname_data.machine, "x86_64") != 0) > fix_32bit_kernel_structs = 1; > > That means: > > * once the x86_64 kernel is fixed to use the correct compat ABI, > this patch will break userspace! > > * the test is wrong anyway. On other 64-bit platforms with compat > support the problem still exists just like before. [...]
The test is probably right; i386 and (presumably) x32 are the only architectures that don't have 64-bit alignment for long long. Ben. -- Ben Hutchings For every complex problem there is a solution that is simple, neat, and wrong.
signature.asc
Description: This is a digitally signed message part
