Package: timidity-daemon
Version: 2.13.2-40.1
Severity: normal
Hello.
I noticed that the timidity initscript displays the message "No timidity
found running; none killed." when called with the stop parameter, thus
uglifying the shutdown process:
# /etc/init.d/timidity stop
[....] Stopping TiMidity++ ALSA midi emulation...No timidity found
running; none killed.
.. ok
To fix it I've added the "--quiet" parameter to start-stop-daemon called
in stop. See the attached patch.
Thanks.
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 3.5-trunk-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages timidity-daemon depends on:
ii adduser 3.113+nmu3
ii timidity 2.13.2-40.1
timidity-daemon recommends no packages.
timidity-daemon suggests no packages.
-- Configuration Files:
/etc/init.d/timidity changed:
.. /lib/lsb/init-functions
NAME="timidity"
PATH=/sbin:/bin:/usr/sbin:/usr/bin
DAEMON=/usr/bin/${NAME}
DESC="TiMidity++ ALSA midi emulation"
PIDFILE=/var/run/timidity/${NAME}.pid
set -e
test -x ${DAEMON} || exit 0
TIM_ALSASEQ=true
TIM_ALSASEQPARAMS="-B2,8"
[ -r /etc/default/timidity ] && . /etc/default/timidity
if [ "${TIM_ALSASEQ}" != "true" ]; then
log_daemon_msg "Starting" "${NAME}"
log_daemon_msg " (to get timidity as an ALSA Sequencer enable this by
editing the file /etc/default/timidity)"
log_end_msg 0
exit 0
fi
[ -z "$SERVER_USER" ] && SERVER_USER=timidity
[ -z "$SERVER_GROUP" ] && SERVER_GROUP=timidity
if ! getent passwd | grep -q "^${SERVER_USER}:"; then
log_daemon_msg "Server user does not exist. Aborting"
log_end_msg 0
exit 1
fi
if ! getent group | grep -q "^${SERVER_GROUP}:" ; then
log_daemon_msg "Server group does not exist. Aborting"
log_end_msg =
exit 1
fi
PARAMS="${TIM_ALSASEQPARAMS} -iAD"
START="--start --chuid ${SERVER_USER} --quiet --exec ${DAEMON} --pidfile
${PIDFILE} -- ${PARAMS}"
case "$1" in
start)
#log_daemon_msg "Starting" "${NAME}"
[ -d /proc/asound ] && [ -d /dev/snd/ ] || {
log_end_msg 1 || echo -n
log_warning_msg "ALSA is not active, cannot start $DESC"
exit 0
}
log_begin_msg "Starting $DESC..."
mkdir -p /var/run/timidity
chown timidity /var/run/timidity
if start-stop-daemon ${START} < /dev/null >/dev/null 2>&1; then
log_end_msg 0
else
log_end_msg 1
exit 1
fi
;;
stop)
log_begin_msg "Stopping $DESC..."
if start-stop-daemon --stop --quiet --oknodo --pidfile ${PIDFILE} \
--name ${NAME} --retry 10 ; then
log_end_msg 0
else
log_end_msg 1
exit 1
fi
;;
restart|force-reload)
$0 stop
exec $0 start
;;
status)
status_of_proc $DAEMON $NAME
;;
*)
echo "Usage: $0 {start|stop|restart|force-reload|status}" >&2
exit 1
esac
exit 0
-- no debconf information
--- timidity-orig 2010-05-21 12:41:53.000000000 +0300
+++ timidity 2012-11-09 01:36:10.773985803 +0200
@@ -81,7 +81,7 @@
;;
stop)
log_begin_msg "Stopping $DESC..."
- if start-stop-daemon --stop --oknodo --pidfile ${PIDFILE} \
+ if start-stop-daemon --stop --quiet --oknodo --pidfile ${PIDFILE} \
--name ${NAME} --retry 10 ; then
log_end_msg 0
else
