Package: liferea
Version: 1.8.6-1
Severity: important
Tags: patch
Dragging feeds outside of google reader to the parent node, and then updating
that feed causes liferea to crash.
Upstream bug report is here:
http://sourceforge.net/tracker/index.php?func=detail&aid=2855990&group_id=87005&atid=581684
Upstream patch is here:
http://liferea.git.sourceforge.net/git/gitweb.cgi?p=liferea/liferea;a=commitdiff;h=5f245fe87e8f32ff0e13c2e94addaf6032b806c4#patch2
Backported patch attached.
-- System Information:
Debian Release: wheezy/sid
Architecture: i386 (i686)
Kernel: Linux 3.2.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages liferea depends on:
ii gconf-service 3.2.5-1+build1
ii gconf2 3.2.5-1+build1
ii libatk1.0-0 2.4.0-2
ii libc6 2.13-35
ii libcairo2 1.12.2-2
ii libgconf-2-4 3.2.5-1+build1
ii libgdk-pixbuf2.0-0 2.26.1-1
ii libglib2.0-0 2.33.12+really2.32.4-3
ii libgtk2.0-0 2.24.10-2
ii libice6 2:1.0.8-2
ii libjson-glib-1.0-0 0.14.2-1
ii libnotify4 0.7.5-1
ii libpango1.0-0 1.30.0-1
ii libsm6 2:1.2.1-2
ii libsoup2.4-1 2.38.1-2
ii libsqlite3-0 3.7.13-1
ii libunique-1.0-0 1.1.6-4
ii libwebkitgtk-1.0-0 1.8.1-3.3
ii libxml2 2.8.0+dfsg1-6
ii libxslt1.1 1.1.26-14
ii liferea-data 1.8.6-1
Versions of packages liferea recommends:
ii curl 7.26.0-1
ii dbus 1.6.8-1
ii dbus-x11 1.6.8-1
ii kget 4:4.8.4-1+b1
ii wget 1.13.4-3
Versions of packages liferea suggests:
ii network-manager 0.9.4.0-6
-- no debconf information
>From 5f245fe87e8f32ff0e13c2e94addaf6032b806c4 Mon Sep 17 00:00:00 2001
From: Lars Windolf <lars.lind...@gmail.com>
Date: Mon, 30 Jul 2012 23:26:01 +0200
Subject: [PATCH] Fixes SF #2855990: Crash when dragging Google Reader feeds outside Google Reader. This is now prevented. (reported by algnod)
---
ChangeLog | 3 +++
src/ui/ui_dnd.c | 9 ++++++++-
2 files changed, 11 insertions(+), 1 deletions(-)
--- a/src/ui/ui_dnd.c
+++ b/src/ui/ui_dnd.c
@@ -105,7 +105,7 @@
iterator to insert after). In any case we have to check
if it is a writeable node source. */
- /* never drop into read-only subscription node sources */
+ /* Never drop into read-only subscription node sources */
if (!(NODE_SOURCE_TYPE (targetNode)->capabilities & NODE_SOURCE_CAPABILITY_WRITABLE_FEEDLIST))
return FALSE;
@@ -116,6 +116,13 @@
if (gtk_tree_model_get_iter (GTK_TREE_MODEL (model), &iter, src_path)) {
gtk_tree_model_get (GTK_TREE_MODEL (model), &iter, FS_PTR, &sourceNode, -1);
+ g_assert (sourceNode);
+
+ /* Never drop into another node source as this arises to many problems
+ (e.g. remote sync, different subscription type, e.g. SF #2855990) */
+ if (NODE_SOURCE_TYPE (targetNode) != NODE_SOURCE_TYPE (sourceNode))
+ return FALSE;
+
if (IS_FOLDER(sourceNode) && !(NODE_SOURCE_TYPE (targetNode)->capabilities & NODE_SOURCE_CAPABILITY_HIERARCHIC_FEEDLIST))
return FALSE;
}
