Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
I humbly request that the release team allow the recently uploaded
python-larch package version 1.20121006-1 into wheezy before the
release. It fixes two bugs, one of which was reported to Debian:
* #675818: UnboundLocalError: local variable 'new_node' referenced
before assignment
- this bug is of normal severity, but could arguably be important
- what happens is that when the "fsck" feature of Obnam (my backup
program) is used in "fix problems and do not just report them"
mode, the program crashes because of an unknown local variable
name
- the problem is that I had inadvertently indented a line wrongly:
the line logs the value of a variable, but is not indented to be
inside the block in which the variable exists
- the fix is a one-line change to indent the problematic line to
the correct level
* the unreported problem is that the package is using the cmdtest tool
during build time to run tests, but is lacking this in the build
dependencies
- I apologise profusely for not reporting a bug for this myself
I am also upstream of python-larch, and have chosen to make a new
upstream release to include these fixes. I hope that is not a problem
for the release team.
An additional change, apart from a new entry in the NEWS file, is
that I fixed the spelling of the name of the person who developed the
B-tree variant the python-larch package implements.
The debdiff is below.
I hope the release team is in good health, and that this request of
mine leaves you in good spirits.
diff -Nru python-larch-1.20120527/debian/changelog
python-larch-1.20121006/debian/changelog
--- python-larch-1.20120527/debian/changelog 2012-10-06 11:59:01.000000000
+0100
+++ python-larch-1.20121006/debian/changelog 2012-10-06 11:59:01.000000000
+0100
@@ -1,3 +1,12 @@
+python-larch (1.20121006-1) unstable; urgency=low
+
+ * New upstream release.
+ - Fix "UnboundLocalError: local variable 'new_node' referenced before
+ assignment" (Closes: #675818)
+ * debian/control: Add missing build-dependency on cmdtest.
+
+ -- Lars Wirzenius <l...@liw.fi> Sat, 06 Oct 2012 10:27:20 +0100
+
python-larch (1.20120527-1) unstable; urgency=low
* New upstream release.
diff -Nru python-larch-1.20120527/debian/control
python-larch-1.20121006/debian/control
--- python-larch-1.20120527/debian/control 2012-10-06 11:59:01.000000000
+0100
+++ python-larch-1.20121006/debian/control 2012-10-06 11:59:01.000000000
+0100
@@ -5,7 +5,7 @@
Standards-Version: 3.9.3
Build-Depends: debhelper (>= 7.3.8), python (>= 2.6.6-3~),
python-coverage-test-runner, python-tracing, python-sphinx,
- python-cliapp (>= 0.14), python-ttystatus
+ python-cliapp (>= 0.14), python-ttystatus, cmdtest
X-Python-Version: >= 2.6
Package: python-larch
diff -Nru python-larch-1.20120527/larch/fsck.py
python-larch-1.20121006/larch/fsck.py
--- python-larch-1.20120527/larch/fsck.py 2012-05-27 10:44:29.000000000
+0100
+++ python-larch-1.20121006/larch/fsck.py 2012-10-06 10:30:43.000000000
+0100
@@ -104,7 +104,7 @@
new_node = larch.IndexNode(node.id, keys,
[node[k] for k in keys])
self.fsck.forest.node_store.put_node(new_node)
- tracing.trace('fixed it: %s' % new_node.keys())
+ tracing.trace('fixed it: %s' % new_node.keys())
class CheckRoot(WorkItem):
diff -Nru python-larch-1.20120527/larch/__init__.py
python-larch-1.20121006/larch/__init__.py
--- python-larch-1.20120527/larch/__init__.py 2012-05-27 10:44:29.000000000
+0100
+++ python-larch-1.20121006/larch/__init__.py 2012-10-06 10:30:43.000000000
+0100
@@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-__version__ = '1.20120527'
+__version__ = '1.20121006'
class Error(Exception):
diff -Nru python-larch-1.20120527/NEWS python-larch-1.20121006/NEWS
--- python-larch-1.20120527/NEWS 2012-05-27 10:44:29.000000000 +0100
+++ python-larch-1.20121006/NEWS 2012-10-06 10:30:43.000000000 +0100
@@ -2,7 +2,16 @@
==============
These are the release notes for larch, a Python implementation of a
-copy-on-write B-tree, designed by Odah Rodeh.
+copy-on-write B-tree, designed by Ohad Rodeh.
+
+Version 1.20121006
+------------------
+
+* Critical bug fix: an indentation problem in the Python code was fixed.
+ A line was intended wrong, resulting it to not be included in the right
+ block, and therefore not having access to the variable created in that
+ block.
+* Bug fix: The Debian packaging was missing a build dependency on cmdtest.
Version 1.20120527, released 2012-05-27
---------------------------------------
unblock python-larch/1.20121006-1
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
