Package: po-debconf
Version: 1.0.16+nmu2
Severity: normal
Tags: patch

Hello,
I think I spotted a bug in podebconf-report-po.

When called without any gzip-related command-line option (that is to say:
without --gzip or --nogzip), but with "gzip" in the configuration file,
podebconf-report-po fails to compress the attachments with gzip.

In other words, the line "gzip" in the configuration file is completely
ignored and the default behavior (no compression) is followed, unless
command-line options impose otherwise.

For instance, the following will send uncompressed attachments:

  $ podebconf-report-po --call --withtranslators \
                        --conf po/.podebconf-report-po.conf

even when po/.podebconf-report-po.conf includes a "gzip" line:

  $ po/.podebconf-report-po.conf 
  languageteam
  addlanguageteam = da:Danish <debian-l10n-dan...@lists.debian.org>
  addlanguageteam = eu:Basque <debian-l10n-bas...@lists.debian.org>
  addlanguageteam = pt:Portuguese <debian-l10n-portugu...@lists.debian.org>
  addlanguageteam = sk:Slovak <debian-l10n-slo...@lists.debian.org>

  deadline = +20days

  nodefault
  noforce
  gzip
  utf8

  summary


The attached patch fixes the issue for me (I tested it in multiple
possible combinations of command-line options and configuration file
contents: It Works For Me™).

Please note that my patch is so trivial, that I think it is not
copyrighted: that's why I didn't add any new copyright notice
and why I believe no license is needed from me...


Please apply this patch in order to fix the bug.
Thanks for your time!


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages po-debconf depends on:
ii  gettext          0.18.1.1-9
ii  intltool-debian  0.35.0+20060710.1
ii  perl             5.14.2-13

Versions of packages po-debconf recommends:
ii  libio-compress-perl [libcompress-zlib-perl]  2.052-1
ii  libmail-sendmail-perl                        0.79.16-1
ii  perl [libcompress-zlib-perl]                 5.14.2-13

Versions of packages po-debconf suggests:
ii  libmail-box-perl  2.105-1

-- no debconf information

Attachment: podebconf-report-po_fixgzip.diff.gz
Description: GNU Zip compressed data

Reply via email to