On Wed, 12 Sep 2012 16:52:34 +0200, gregor herrmann wrote:

[ http://bugs.debian.org/687403 ]

> From staring at the patch:
> 
> http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libio-async-perl.git;a=commitdiff;h=c9312eb
> 
> ++# Some Loop implementations do not accurately handle sub-second timers.
> ++# This only matters for unit tests
> ++use constant _CAN_SUBSECOND_ACCURATELY => 1;
> 
> ++   SKIP: {
> ++      skip "Unable to handle sub-second timers accurately", 3 unless 
> $loop->_CAN_SUBSECOND_ACCURATELY;
> 
> 
> Should this be "_CAN_SUBSECOND_ACCURATELY => 0" to turn it off unless
> some loop test explicitly sets it?

Ok, some investigation:
The tests can either be skipped by
- either setting _CAN_SUBSECOND_ACCURATELY to 0 in libio-async-perl
- or in libio-async-loop-epoll-perl

Both patches attached.


Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: Über den Berg
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..8b3120d
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+subseconds.patch
diff --git a/debian/patches/subseconds.patch b/debian/patches/subseconds.patch
new file mode 100644
index 0000000..cb4f94b
--- /dev/null
+++ b/debian/patches/subseconds.patch
@@ -0,0 +1,11 @@
+--- a/lib/IO/Async/Loop/Epoll.pm
++++ b/lib/IO/Async/Loop/Epoll.pm
+@@ -17,6 +17,8 @@
+ # doesn't harm anything to test specially.
+ use constant _CAN_ON_HANGUP => ( $^O eq "linux" );
+ 
++use constant _CAN_SUBSECOND_ACCURATELY => 0;
++
+ use base qw( IO::Async::Loop );
+ 
+ use Carp;
diff --git a/debian/patches/subsecond.patch b/debian/patches/subsecond.patch
index a80d8ce..7307821 100644
--- a/debian/patches/subsecond.patch
+++ b/debian/patches/subsecond.patch
@@ -24,7 +24,7 @@ Subject: Allow Loops to declare for unit-test purposes that they can't
  
 +# Some Loop implementations do not accurately handle sub-second timers.
 +# This only matters for unit tests
-+use constant _CAN_SUBSECOND_ACCURATELY => 1;
++use constant _CAN_SUBSECOND_ACCURATELY => 0;
 +
  use Carp;
  

Attachment: signature.asc
Description: Digital signature

Reply via email to