Hello:
Thanks a lot for your review.
On 18/09/12 09:56, olivier.sal...@codeless.fr wrote:
Hi,
I cloned git repository to build the package.
Here are my first comments. I gonna continue to have a look to the package.
I used the get-orig-source target to download source package.
It fails with git-buildpackage (see below).
I am not surprised that git-buildpacakge fails because I have not played with
it:
I will revisit my stuff accordingly soon.
Your clean target remove files that are inconsistent with the source
tarball.
After a clean, you should get same content than source.
idem
It seems you regenerate the pdf in doc. This is not mandatory if you
provide the source (what you do).
The texinfo source has to be patched to satisfied some Debian policy point:
the regeneration of the PDF doc is so mandatory here.
So either you build the pdf but must be able to go back to "source"
status after a clean, either you remove the pdf from the source tarball,
either you do not regenerate the pdf.
The PDF is removed from the tarball and must be generated:
I have to clean up my clean target.
In debian/copyright, copyright should be Mickael Gastineau AND
IMCCE-CNRS. Header files specifiy the IMCCE-CNRS affiliation.
my mistake.
osallou@debiansid:~/DEBIAN-SCIENCE/scscp-imcce$ git-buildpackage
dh clean --with autoreconf
dh_testdir
debian/rules override_dh_auto_clean
make[1]: Entering directory `/home/osallou/DEBIAN-SCIENCE/scscp-imcce'
rm -rf doc/stamp-vti doc/version.texi doc/scscp.info
dh_auto_clean
make[1]: Leaving directory `/home/osallou/DEBIAN-SCIENCE/scscp-imcce'
dh_autoreconf_clean
dh_clean
gbp:error: You have uncommitted changes in your source tree:
gbp:error: # On branch debian
# Changed but not updated:
# (use "git add/rm<file>..." to update what will be committed)
# (use "git checkout --<file>..." to discard changes in working
directory)
#
# deleted: doc/scscp.info
# deleted: doc/stamp-vti
# deleted: doc/version.texi
#
no changes added to commit (use "git add" and/or "git commit -a")
gbp:error: Use --git-ignore-new to ignore.
I will work on the part soon.
Best wishes,
Jerome
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
