Package: meterec
Version: 0.9.1~ds0-1
Severity: normal
Tags: patch

Dear Maintainer,

The CPPFLAGS hardening flags are missing because are overwritten
in ./configure (and ./configure.in).

The attached patch fixes the issue, the ./configure.in part
should be sent upstream.

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log with `blhc` (hardening-check doesn't catch
everything):

    $ hardening-check /usr/bin/meterec
    /usr/bin/meterec:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Description: Use CPPFLAGS from environment (dpkg-buildflags).
 Necessary for hardening flags.
Author: Simon Ruderich <si...@ruderich.org>
Last-Update: 2012-09-08

--- meterec-0.9.1~ds0.orig/configure
+++ meterec-0.9.1~ds0/configure
@@ -3569,7 +3569,7 @@ PACKAGE_CFLAGS="-g -Wall $SNDFILE_CFLAGS
 PACKAGE_LIBS="$SNDFILE_LIBS $JACK_LIBS $LIBCONFIG_LIBS"
 
 CFLAGS="$CFLAGS $PACKAGE_CFLAGS "
-CPPFLAGS="$CFLAGS $PACKAGE_CFLAGS "
+CPPFLAGS="$CPPFLAGS $PACKAGE_CFLAGS "
 
 ac_ext=c
 ac_cpp='$CPP $CPPFLAGS'
--- meterec-0.9.1~ds0.orig/configure.in
+++ meterec-0.9.1~ds0/configure.in
@@ -24,7 +24,7 @@ PACKAGE_CFLAGS="-g -Wall $SNDFILE_CFLAGS
 PACKAGE_LIBS="$SNDFILE_LIBS $JACK_LIBS $LIBCONFIG_LIBS"
 
 CFLAGS="$CFLAGS $PACKAGE_CFLAGS "
-CPPFLAGS="$CFLAGS $PACKAGE_CFLAGS "
+CPPFLAGS="$CPPFLAGS $PACKAGE_CFLAGS "
 
 AC_CHECK_HEADERS(jack/session.h)
 

Attachment: signature.asc
Description: Digital signature

Reply via email to