Package: abcde Version: 2.5.3-1 Severity: important During a network outage, I attempted to rip a CD and noticed that an endless loop of calls to cddb-tool were being generated, together with around 100kB/s of traffic to the local DNS resolver. The responses from the DNS server were SERVFAIL.
dom@callisto:~$ cddb-tool stat http://freedb.freedb.org/~cddb/cddb.cgi dom callisto 6 dom@callisto:~$ echo $? 4 The infinite loop is apparent in do_cddbstat (); the loop should be broken on error in the inner 'case' statement of this loop (the main loop only takes account of the possibility that the CDDB protocol is not supported). I'm marking this as important, because this results in wasteful network utilization, but I'm not particularly attached to this severity. Trivial patch attached. -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 3.2.0-3-686-pae (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages abcde depends on: ii cd-discid 1.3.1-1 ii cdparanoia 3.10.2+debian-10.1 ii flac 1.2.1-6 ii icedax 9:1.1.11-2 ii speex 1.2~rc1-6 ii vorbis-tools 1.4.0-1 ii wget 1.13.4-3 Versions of packages abcde recommends: ii libdigest-sha-perl 5.71-1 pn libmusicbrainz-discid-perl <none> pn libwebservice-musicbrainz-perl <none> ii mailutils [mailx] 1:2.99.97-3 ii perl [libdigest-sha-perl] 5.14.2-13 ii vorbis-tools 1.4.0-1 Versions of packages abcde suggests: ii atomicparsley 0.9.2~svn110-4 pn distmp3 <none> ii eject 2.1.5+deb1+cvs20081104-11 pn eyed3 <none> ii id3 0.15-3 ii id3v2 0.1.12-2 pn mkcue <none> pn mp3gain <none> pn normalize-audio <none> pn vorbisgain <none> -- Configuration Files: /etc/abcde.conf changed: OGGENCOPTS='-q 4.6' OUTPUTDIR=`pwd` WAVOUTPUTDIR=/data/scratch/wav OUTPUTTYPE=flac OUTPUTFORMAT='${ARTISTFILE}/${ALBUMFILE}/${TRACKNUM}-${TRACKFILE}' VAOUTPUTFORMAT='${ALBUMFILE}/${TRACKNUM}-${ARTISTFILE}-${TRACKFILE}' MAXPROCS=2 -- no debconf information
--- /usr/bin/abcde 2012-06-16 16:08:33.000000000 +0100 +++ /tmp/abcde 2012-09-07 13:34:55.000000000 +0100 @@ -2400,6 +2400,10 @@ 2??) # Server responded, everything seems OK rc=0 ;; + *) + # unknown error + break + ;; esac ;; esac
