Control: tags 686881 + patch On 09/06/2012 06:47 PM, Daniel Kahn Gillmor wrote: > there seems to be at least two problems with the postinst script: a > brittle attempt to mkdir /dev/scsi, and some attempts to update-rc.d, > which i found after working around the mkdir error by letting it > blunder through:
on further review, the update-rc.d bugginess has to do with problems with insserv under fakechroot (see http://bugs.debian.org/686965). So the only problem is this hard-coded attempt to create /dev/scsi in the first place. Note that this attempt to create /dev/scsi isn't going to persist on modern systems with a tmpfs mounted on /dev, so whatever is relying on that directory being there is going to need some other way to deal after a reboot anyway. Given this situation, the main problem with this bug is that the postinst fails when unable to create the directory. I'm attaching a patch to make the postinst script less brittle. Fixing this bug would let us include scsitools in the default debirf rescue image, which has been requested by some users. Regards, --dkg
diff -ruN scsitools-0.12.clean/debian/postinst scsitools-0.12/debian/postinst --- scsitools-0.12.clean/debian/postinst 2011-01-21 16:39:27.000000000 -0500 +++ scsitools-0.12/debian/postinst 2012-09-07 16:08:21.048293064 -0400 @@ -3,7 +3,7 @@ #DEBHELPER# if [ "$1" = "configure" ]; then - test -d /dev/scsi || mkdir --mode=755 /dev/scsi + test -d /dev/scsi || mkdir --mode=755 /dev/scsi || true # first part before activating swap & remounting / rw update-rc.d scsitools-pre.sh start 09 S . >/dev/null # second part after modutils was run but before mounting other devices
signature.asc
Description: OpenPGP digital signature
