Package: distcc
Version: 2.18.3-3
Severity: normal

current code in /etc/init.d/distcc reads:

    case "$1" in
      start)
            should_start
            echo -n "Starting $DESC: $NAME"
            start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
            --chuid distccd \
            --exec $DAEMON -- $DAEMON_ARGS $ALLOW $LISTENER
            echo "."
            ;;
 
In case of failure, the "set -e" used previously terminates the command
and user does not get eny indictation in case of failure. This causes
assuming that the command succeeded:

   # /etc/init.d/distcc start
   <nothing>

only after couple of hours or days he may suspect that the service is not
up. Perhaps the code could be improved to that a message is displayed
in case of error. Something like (untested):

    case "$1" in
      start)
            should_start
            echo -n "Starting $DESC: $NAME"
            start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
            --chuid distccd \
            --exec $DAEMON -- $DAEMON_ARGS $ALLOW $LISTENER ||
            {
                code=$?
                echo "$0: start failed with error code $code" >&2
                exit $code
            }
            echo "."
            ;;

Similarly with other "stop|restart|force-reload"

-- Package-specific info:

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=C, LC_CTYPE=C (charmap=ISO-8859-1) (ignored: LC_ALL set to en_US)

Versions of packages distcc depends on:
ii  adduser                       3.67.2     Add and remove users and groups
ii  debconf [debconf-2.0]         1.4.58     Debian configuration management sy
ii  libc6                         2.3.5-6    GNU C Library: Shared libraries an
ii  libpopt0                      1.7-5      lib for parsing cmdline parameters
ii  netbase                       4.22       Basic TCP/IP networking system

distcc recommends no packages.

-- debconf information excluded


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to