Am Dienstag, den 11.10.2005, 21:02 +0200 schrieb Ola Lundqvist: > Hello > > On Tue, Oct 11, 2005 at 08:28:54PM +0200, Daniel Leidert wrote: > > Am Dienstag, den 11.10.2005, 08:15 +0200 schrieb Ola Lundqvist: > > > On Mon, Oct 10, 2005 at 10:14:52PM +0200, Daniel Leidert wrote: > > > > [..] > > > > Then there is a bug in generateRelease(). The code is as follows > > > > > > > > if ($gpgkey) { > > > > cmdaction("$signcmd '$path/Release' '$path/Release.gpg' ". > > > > "'$gpgkey' '$gpgpassfile'", > > > > "Signing Release file for $path with key '$gpgkey'", > > > > 3); > > > > } > > > > > > > > But now the problem is, that if there is no gpgpassfile defined in > > > > /etc/debarchiver.conf (e.g. the variable is commented out and not set to > > > > ""), gpgpassfile is set to null: > > > > > > > > if ($gpgpassfile) { > > > > $gpgpassfile = 0 if (! -f $gpgpassfile); > > > > } > > [..] > > > Do you have a patch or do you want me to simply make the changes myself? > > > > Pleaes check the attached patch. It works perfectly for me. It tries to > > make a fallback if $gpgpassfile is NULL or if the value is a > > non-existing file. > > > > This should do. > > Ok, looks good. Applying now. > > Thanks a lot.
Hello Ola, It seems you forgot to fix the $signcmd-default in debarchiver.conf and in debarchiver.pl. Both only contain the path, not the executable. And you did not include my proposed paragraph for $gpgpassfile in debarchiver.conf. You should at least fix the $signcmd variable in both mentioned files. I'm going to fix the READMEs to mention the right way to create signed Release files. If you want to wait with 0.5.2 until this is ready, I will go to fix the forgotten issues, so you don't have to. PS: This mail was sent as copy to recently closed BTS entry #333182. Regards, Daniel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]