Thanks, I also changed it for modprobe_multi().
But you're right: kmod should really show some kind of error when it
fails to load a module, although the reasoning behind it, could be that
it somehow detects that the module is build-in and therefor silences its
error... Wouldn't hurt to report this to the maintainer though.
cheers,
Arno
On 10-Aug-12 19:16, Wojciech Kusiak wrote:
On Fri, Aug 10, 2012 at 07:40:27AM +0200, Arno van Amersfoort wrote:
I think I managed to work around the issue, although I think kmod
should of course return a more descriptive (error) message when a
module is not found.
Totally agreed .
If it's documented somewhere that return 1 means "module not found"
in particular, and other errors use different codes, it's slightly
less wrong, but still, interactive-use programs should print a message
on errors.
Not many people have their shells set to print last command's return
value.
Of course, this is software with bugs like #665873 and #676387...
Since I don't have a system with kmod here I can't test the fix. If you like
you can grab the latest nightly from
http://rocky.eld.leidenuniv.nl/arno-iptables-firewall/arno-iptables-firewall_nightly.tar.gz
and report back.
Well, actually, it doesn't solve it as you added the empty message
check only to modprobe() and not to modprobe_multi().
But copying it to down there indeed silences the printouts.
Of course, now it will not print any warning if kmod (or modprobe,
for that matter) will return another error code without a message.
Lose-lose situation, I guess. :(
Thanks a lot for looking into this, and for the script itself too. :)
Regards,
-- Wojciech
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
