Am 24.07.2012 16:13, schrieb Nelson A. de Oliveira:
> Package: geoip-database-contrib
> Version: 1.7
> Severity: minor
> 
> Hi!
> 
> In geoip-database-contrib_update we can see that it first deletes the old
> database and then tries to download a new version.
> I see one small problem here: suppose there is a network problem and
> it's not possible to download the new database; we stay without the old
> version (that was removed) and without the new version (that couldn't be
> downloaded).

Are you sure?
$FILE is the basename of the downloading URL, which is stripped down to
e.g. GeoIPv6.dat.gz.
So the first rm -f $FILE only deletes the compressed databases (which
are not used).
Then:

/usr/bin/wget -t3 -T15 -P /usr/share/GeoIP/ "$url" && \
        /bin/gunzip -f /usr/share/GeoIP/$FILE

So gunzip only will get executed (and so on overwriting the database),
if wget was successful (&&).

> 
> Would be good if we could stay with the old version if the new one has
> failed (old data is better than no data).
> 


-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatth...@debian.org
        patr...@linux-dev.org
*/

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to