retitle 682803 trn4: Segfault whilst applying killfile to article with long header line tag 682803 +patch thanks
This now reminds me of some investigations I did a few years back into a similar issue in inn's nntpget. I found that a small number of clients did not trim References headers when they grew past 1024 bytes, or perhaps trimmed before appending the new message-id rather than afterwards. Regardless, the number of articles with References headers > 1024 was non-zero, but few had them very much longer than that as most of these lengthy subthreads involved at least one person with a non-broken newsreader. I therefore think the attached patch should be more than adequate. Tested here and solves the problem on all the newsgroups I'm subscribed to that have long enough threads to cause this issue. Thanks Nick
Index: trn4-4.0-test77/common.h =================================================================== --- trn4-4.0-test77.orig/common.h 2012-08-01 21:05:03.000000000 +0100 +++ trn4-4.0-test77/common.h 2012-08-01 21:05:09.000000000 +0100 @@ -55,7 +55,7 @@ #include "typedef.h" #define BITSPERBYTE 8 -#define LBUFLEN 1024 /* line buffer length */ +#define LBUFLEN 2048 /* line buffer length */ /* (don't worry, .newsrc lines can exceed this) */ #define CBUFLEN 512 /* command buffer length */ #define PUSHSIZE 256
